[3.x] Implement PHPStan #596
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -261,7 +274,7 @@ protected function bootListeners(): self | |||
| protected function bootMacros(): self | |||
| { | |||
| Collection::macro('firstForCurrentStore', function () { | |||
| /** @var Collection $this */ | |||
| /** @var Collection<> $this */ | |||
There was a problem hiding this comment.
Works out to a Collection<mixed> type by default, which is what you want here with the macro. I could specify it explicitly if preferable?
indykoning
reviewed
Oct 17, 2024
|
Do we really want level 8 with all those ignores? And a bit to many docblocks if you ask me. Laravel itself is running level 1: https://github.com/laravel/framework/blob/11.x/phpstan.src.neon.dist |
|
I agree with @royduin . Also quite a few ignores. Rather have a lower level then this much ignores. |
|
I've lowered it to level 1, allowing me to also make a specific ignore for all eventy errors, which removed all but one of the remaining phpstan ignores 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds PHPStan as a workflow and fixes all (current) errors that come out of PHPStan level 8.
Includes some other fixes that I happened to come across, for example dynamic models not being used properly.
I've done a quick test on an existing project to see if I've made any errors, but I could not spot any. Nevertheless, this is of course still a hugely breaking change.